Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSC] Some misc cleanup in new BBQ #10433

Commits on Feb 21, 2023

  1. [JSC] Some misc cleanup in new BBQ

    https://bugs.webkit.org/show_bug.cgi?id=252654
    rdar://105714823
    
    Reviewed by Mark Lam.
    
    This patch does some cleanups in new BBQ.
    
    1. Dedup exception throwing code.
    2. Define FPRInfo::nonPreservedNonArgumentFPR0 and use it for m_scratchFPR.
    3. Add boundary offset only when boundary is non-zero.
    
    * Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:
    * Source/JavaScriptCore/jit/FPRInfo.h:
    * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
    (JSC::Wasm::BBQJIT::BBQJIT):
    (JSC::Wasm::BBQJIT::addTableGet):
    (JSC::Wasm::BBQJIT::addTableSet):
    (JSC::Wasm::BBQJIT::addTableInit):
    (JSC::Wasm::BBQJIT::addTableFill):
    (JSC::Wasm::BBQJIT::addTableCopy):
    (JSC::Wasm::BBQJIT::emitCheckAndPreparePointer):
    (JSC::Wasm::BBQJIT::addMemoryFill):
    (JSC::Wasm::BBQJIT::addMemoryCopy):
    (JSC::Wasm::BBQJIT::addMemoryInit):
    (JSC::Wasm::BBQJIT::emitAtomicLoadOp):
    (JSC::Wasm::BBQJIT::emitAtomicStoreOp):
    (JSC::Wasm::BBQJIT::emitAtomicBinaryRMWOp):
    (JSC::Wasm::BBQJIT::emitAtomicCompareExchange):
    (JSC::Wasm::BBQJIT::atomicWait):
    (JSC::Wasm::BBQJIT::atomicNotify):
    (JSC::Wasm::BBQJIT::truncTrapping):
    (JSC::Wasm::BBQJIT::throwExceptionIf):
    (JSC::Wasm::BBQJIT::emitModOrDiv):
    (JSC::Wasm::BBQJIT::addRefAsNonNull):
    (JSC::Wasm::BBQJIT::endTopLevel):
    (JSC::Wasm::BBQJIT::addCallIndirect):
    (JSC::Wasm::BBQJIT::addExceptionLateLinkTask): Deleted.
    * Source/JavaScriptCore/wasm/WasmExceptionType.h:
    
    Canonical link: https://commits.webkit.org/260597@main
    Constellation committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    2a0f7a0 View commit details
    Browse the repository at this point in the history