Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ macOS Debug WK2 ] ASSERT call in RenderVTTCue.cpp causing flaky crash (media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html) #16315

Merged

Conversation

eric-carlson
Copy link
Contributor

@eric-carlson eric-carlson commented Aug 2, 2023

83a6562

[ macOS Debug WK2 ] ASSERT call in RenderVTTCue.cpp causing flaky crash (media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html)
https://bugs.webkit.org/show_bug.cgi?id=259544
rdar://112951082

Reviewed by Jer Noble.

Remove two unneeded asserts. Both checked a condition that is commonly encountered and which
is not dangerous or harmful.

* LayoutTests/platform/mac-wk2/TestExpectations: Unskip test.

* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::repositionCueSnapToLinesSet): Remove assert.
(WebCore::RenderVTTCue::repositionGenericCue): Ditto.

Canonical link: https://commits.webkit.org/266513@main

e93be53

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@eric-carlson eric-carlson self-assigned this Aug 2, 2023
@eric-carlson eric-carlson added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Aug 2, 2023
@eric-carlson eric-carlson added the merge-queue Applied to send a pull request to merge-queue label Aug 2, 2023
…sh (media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html)

https://bugs.webkit.org/show_bug.cgi?id=259544
rdar://112951082

Reviewed by Jer Noble.

Remove two unneeded asserts. Both checked a condition that is commonly encountered and which
is not dangerous or harmful.

* LayoutTests/platform/mac-wk2/TestExpectations: Unskip test.

* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::repositionCueSnapToLinesSet): Remove assert.
(WebCore::RenderVTTCue::repositionGenericCue): Ditto.

Canonical link: https://commits.webkit.org/266513@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266513@main (83a6562): https://commits.webkit.org/266513@main

Reviewed commits have been landed. Closing PR #16315 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 83a6562 into WebKit:main Aug 2, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
4 participants