-
-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source strings needing work locks all translations #11288
Comments
This is intentional, if somebody is going to rewrite the source string, the translations will need to be fixed after that anyway. |
Mistakes in source strings don't always propagate to the translation though. Lets say the source string is "Url" when it should have been "URL". (It happens X) Someone could fix that in their own language, and logically go to the source string to mark it as needing work. Or fix it in all translated languages, and then mark as needing work for the source? That locks all new languages. So what problems are buried here? Does the platform want to facilitate quality, or try to minimize the amount of actual work done? From my point of view I want to fix things when I am there, not down the road. I'd rather take the marked as fuzzy after an update when the string is correct for the user. |
This was originally introduced for #3270. It might make sense to limit this to the workflow with intermediate translation only. |
This issue has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
Make this a warning instead of rejecting edits to such strings. Fixes WeblateOrg#11288
Make this a warning instead of rejecting edits to such strings. Fixes #11288
Thank you for your report; the issue you have reported has just been fixed.
|
Describe the issue
If for whatever reason the source string is marked as needing work,
it means all translations thereof are locked.
This means no other issues in the translate to-languages can be fixed meanwhile.
I already tried
Steps to reproduce the behavior
Expected behavior
Would expect all translatable strings to be editable.
Screenshots
Here it should be "E-post-oppsettsveiviser"
Exception traceback
No response
How do you run Weblate?
weblate.org service
Weblate versions
No response
Weblate deploy checks
No response
Additional context
Also, https://hosted.weblate.org/translate/ubports/app-dekko/nb_NO/?checksum=40f7a65819757880
As a rule I want to correct the mistakes of others and myself when I am able to, and not on the assumption that
the source string is always the issue.
As long as the string is used, it at least removes insult from injury.
It is better to have a correctly typed string rather than one that is wrong and badly mistyped.
If that removes the "needs work" in the translated to-language, it is a problem with having one
checkbox.
Just the one checkbox creates similar issues when there is assumptions made over what the original error was, and its correction.
I think having it editable now, and then also possibly notifying all people adding "needs work" that their issue was attemptedly fixed is a good quickfix.
The text was updated successfully, but these errors were encountered: