Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: inconsistent path for serving static files #9601

Closed
2 tasks done
surli opened this issue Jul 19, 2023 · 2 comments · Fixed by #9605
Closed
2 tasks done

doc: inconsistent path for serving static files #9601

surli opened this issue Jul 19, 2023 · 2 comments · Fixed by #9605
Assignees
Labels
documentation Improvements or additions to the documentation.
Milestone

Comments

@surli
Copy link
Contributor

surli commented Jul 19, 2023

Describe the issue

There is an inconsistency in the documentation regarding serving the static files.
In settings_example.py there is since 4.16:
STATIC_ROOT = os.path.join(CACHE_DIR, "static")

Before 4.16 this value was:
STATIC_ROOT = os.path.join(DATA_DIR, "static")

The impact of this change is that all documentation talking about serving static file should point out that those files are coming from the CACHE_DIR, e.g. in https://docs.weblate.org/en/latest/admin/install.html#serving-static-files and in particular in https://docs.weblate.org/en/latest/admin/install.html#sample-configuration-for-nginx-and-uwsgi where the paths are now wrong.

I just had the issue when performing an upgrade: suddenly my static files were not properly served anymore. I had to change my nginx configuration to fix the problem.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Upgrade weblate from 4.15 to 4.16 and apply the changes in settings_example.py

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

nijel added a commit to nijel/weblate that referenced this issue Jul 20, 2023
nijel added a commit to nijel/weblate that referenced this issue Jul 20, 2023
@nijel nijel added the documentation Improvements or additions to the documentation. label Jul 20, 2023
@nijel nijel added this to the 5.0 milestone Jul 20, 2023
@nijel nijel mentioned this issue Jul 20, 2023
5 tasks
@nijel
Copy link
Member

nijel commented Jul 20, 2023

Should be addressed by #9605, review is welcome.

@nijel nijel self-assigned this Jul 20, 2023
nijel added a commit to nijel/weblate that referenced this issue Jul 20, 2023
- Fixed example configration to match CACHE_DIR usage
- Move DATA_DIR sections which now live in CACHE_DIR
- Document new CACHE_DIR entries

Fixes WeblateOrg#9601
nijel added a commit to nijel/weblate that referenced this issue Jul 20, 2023
- Fixed example configration to match CACHE_DIR usage
- Move DATA_DIR sections which now live in CACHE_DIR
- Document new CACHE_DIR entries

Fixes WeblateOrg#9601
nijel added a commit to nijel/weblate that referenced this issue Jul 20, 2023
- Fixed example configration to match CACHE_DIR usage
- Move DATA_DIR sections which now live in CACHE_DIR
- Document new CACHE_DIR entries
- Document change in the upgrading instructions

Fixes WeblateOrg#9601
nijel added a commit to nijel/weblate that referenced this issue Jul 20, 2023
- Fixed example configration to match CACHE_DIR usage
- Move DATA_DIR sections which now live in CACHE_DIR
- Document new CACHE_DIR entries
- Document change in the upgrading instructions

Fixes WeblateOrg#9601
nijel added a commit to nijel/weblate that referenced this issue Jul 20, 2023
- Fixed example configration to match CACHE_DIR usage
- Move DATA_DIR sections which now live in CACHE_DIR
- Document new CACHE_DIR entries
- Document change in the upgrading instructions

Fixes WeblateOrg#9601
nijel added a commit that referenced this issue Aug 1, 2023
- Fixed example configration to match CACHE_DIR usage
- Move DATA_DIR sections which now live in CACHE_DIR
- Document new CACHE_DIR entries
- Document change in the upgrading instructions

Fixes #9601
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants