Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CACHE_DIR documentation #9605

Merged
merged 1 commit into from
Aug 1, 2023
Merged

CACHE_DIR documentation #9605

merged 1 commit into from
Aug 1, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Jul 20, 2023

Proposed changes

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.0 milestone Jul 20, 2023
@nijel nijel requested a review from orangesunny as a code owner July 20, 2023 07:57
@surli
Copy link
Contributor

surli commented Jul 20, 2023

It's probably worth adding also a mention in upgrade from 4.15 to 4.16 to be careful with this.

@nijel nijel force-pushed the cache branch 3 times, most recently from 0858114 to a4ddd84 Compare July 20, 2023 09:15
@nijel
Copy link
Member Author

nijel commented Jul 20, 2023

I've added mention to the upgrade instructions as well.

@surli
Copy link
Contributor

surli commented Jul 20, 2023

LGTM

- Fixed example configration to match CACHE_DIR usage
- Move DATA_DIR sections which now live in CACHE_DIR
- Document new CACHE_DIR entries
- Document change in the upgrading instructions

Fixes WeblateOrg#9601
@nijel nijel merged commit 63a2f22 into WeblateOrg:main Aug 1, 2023
22 checks passed
@nijel nijel deleted the cache branch August 1, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: inconsistent path for serving static files
3 participants