Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit terminology entries to adding user #9661

Closed
2 tasks done
yilmazdurmaz opened this issue Aug 1, 2023 · 6 comments · Fixed by #9663
Closed
2 tasks done

Credit terminology entries to adding user #9661

yilmazdurmaz opened this issue Aug 1, 2023 · 6 comments · Fixed by #9663
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@yilmazdurmaz
Copy link
Contributor

Describe the issue

The name is "None" and without any profile.. Since the name does not ring anything for a real person, I take it as some kind of AI-like system user.

And it has gone rogue for quite some time. It adds new items to the glossary no one asked for, sometimes acceptable, but mostly lots of nonsense duplicates.

Below are new addition made by it; most are parts of scripting codes (underscores) and 3 are exact duplicates.

https://hosted.weblate.org/browse/learn-gdscript-from-zero/glossary/tr/?q=state:%3Ctranslated

new glossary item

https://hosted.weblate.org/translate/learn-gdscript-from-zero/glossary/tr/?checksum=8ed571e7e2730eb8&q=state%3A%3Ctranslated

added by None system user

I reported a similar issue before that if I try to delete duplicates, this None would revive them. I haven't heard about that from you yet, so you may take this as a complimentary issue and treat them both equal in fixing the None user.

#9593

Please fix the behaviour of this system user asap.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Just wait because there is no timer for this behavior
    • and then the None will add new items sooner or later, then you will be notified in the daily digest if set.

Expected behavior

The None user should either not

  • add new items into the glossary
  • or have the mind not to add duplicate words, and/or code parts

Screenshots

related screenshots are given under their respective links above

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@yilmazdurmaz yilmazdurmaz changed the title Pleaes fix this (rogue) system user shown as None, who/which adds to glossary but mindlessly Please fix this (rogue) system user shown as None, who/which adds to glossary but mindlessly Aug 1, 2023
@nijel
Copy link
Member

nijel commented Aug 1, 2023

There is no AI in this, it's just operations which can't be accounted to any user. See also #3009.

In this particular case, the term was added upon commit to the language because of the terminology flag. And it is there four times because somebody added it there four times: https://hosted.weblate.org/translate/learn-gdscript-from-zero/glossary/en/?checksum=241ff434c9eab98e#others

@nijel nijel added the question This is more a question for the support than an issue. label Aug 1, 2023
@yilmazdurmaz
Copy link
Contributor Author

Alright then, one mystery is solved. So, these nonsense additions are actually made by some real user but directly into the main language, here English.

I will try to delete these nonsense/duplicate strings from there and see what happens.

@yilmazdurmaz
Copy link
Contributor Author

I am now traversing the English glossary and I can see there are items I added for my language, Turkish.

I thought adding new items to the glossary will only go to my selected/current language's glossary.

But now it is clear it goes back to the main language, and then propagates to other languages.

@nijel , do you know if there is/was any work about separating these two behaviors? not to propagate to other languages?

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This issue has been marked as a question by a Weblate team member. Why? Because it belongs more to the professional Weblate Care or community Discussions than here. We strive to answer these reasonably fast here, too, but purchasing the support subscription is more responsible and faster for your business. And it makes Weblate stronger as well. Thanks!

In case your question is already answered, making a donation is the right way to say thank you!

@nijel nijel self-assigned this Aug 1, 2023
@nijel nijel added enhancement Adding or requesting a new feature. and removed question This is more a question for the support than an issue. labels Aug 1, 2023
@nijel nijel added this to the 5.0 milestone Aug 1, 2023
@nijel
Copy link
Member

nijel commented Aug 1, 2023

If you don't mark the string as terminology it will be in your language only, see https://docs.weblate.org/en/latest/user/glossary.html#terminology.

But I think the terminology entries should be credited to the adding user. I will change that.

@nijel nijel changed the title Please fix this (rogue) system user shown as None, who/which adds to glossary but mindlessly Credit terminology entries to adding user Aug 1, 2023
nijel added a commit to nijel/weblate that referenced this issue Aug 1, 2023
- avoids expensive sync_terminology call on adding every glossary entry
- makes added entries credited to the adding user

Fixes WeblateOrg#9661
nijel added a commit to nijel/weblate that referenced this issue Aug 1, 2023
- avoids expensive sync_terminology call on adding every glossary entry
- makes added entries credited to the adding user

Fixes WeblateOrg#9661
nijel added a commit to nijel/weblate that referenced this issue Aug 2, 2023
- avoids expensive sync_terminology call on adding every glossary entry
- makes added entries credited to the adding user

Fixes WeblateOrg#9661
nijel added a commit that referenced this issue Aug 2, 2023
- avoids expensive sync_terminology call on adding every glossary entry
- makes added entries credited to the adding user

Fixes #9661
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants