Add support for xlsx files #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature provides an external format (Excel workbook) for download and upload. The upload is solved by converting the Excel workbook into a csv file which is used for translation merging addresses #1879 Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com>
Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com>
Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com>
Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com>
Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com>
also catched the BadZipFile exception which may be thrown by openpyxl Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com>
Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com>
Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com> Conflicts: docs/admin/install.rst weblate/templates/translation-download.html
Signed-off-by: Manuel Laggner <manuel.laggner@gmail.com>
See #1888 Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
See #1888 Signed-off-by: Michal Čihař <michal@cihar.com>
It is now basically just a wrapper around CSV and all operations are performed on csvfile, just the save/load operations are wrapped. See #1888 Signed-off-by: Michal Čihař <michal@cihar.com>
Codecov Report
@@ Coverage Diff @@
## master #2164 +/- ##
==========================================
+ Coverage 91.64% 91.65% +<.01%
==========================================
Files 370 372 +2
Lines 25140 25226 +86
Branches 2802 2813 +11
==========================================
+ Hits 23040 23121 +81
- Misses 1329 1333 +4
- Partials 771 772 +1 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bases on #1888
Before submitting pull request, please ensure that: