fix: Crash when closing providers

WerWolv · Jun 16, 2024 · bee4b90 · bee4b90
1 parent b3b79b3
commit bee4b90
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/libimhex/include/hex/api/imhex_api.hpp b/lib/libimhex/include/hex/api/imhex_api.hpp
@@ -293,7 +293,7 @@ namespace hex {
             namespace impl {
 
                 void resetClosingProvider();
-                const std::set<prv::Provider*>& getClosingProviders();
+                std::set<prv::Provider*> getClosingProviders();
 
             }
 

diff --git a/lib/libimhex/source/api/imhex_api.cpp b/lib/libimhex/source/api/imhex_api.cpp
@@ -277,7 +277,7 @@ namespace hex {
                 s_closingProviders.clear();
             }
 
-            const std::set<prv::Provider*>& getClosingProviders() {
+            std::set<prv::Provider*> getClosingProviders() {
                 return s_closingProviders;
             }
 

diff --git a/plugins/builtin/source/content/ui_items.cpp b/plugins/builtin/source/content/ui_items.cpp
@@ -465,7 +465,7 @@ namespace hex::plugin::builtin {
                         auto &tabProvider = providers[i];
                         const auto selectedProviderIndex = ImHexApi::Provider::getCurrentProviderIndex();
 
-                        const auto &closingProviders = ImHexApi::Provider::impl::getClosingProviders();
+                        const auto closingProviders = ImHexApi::Provider::impl::getClosingProviders();
                         if (std::ranges::find(closingProviders, tabProvider) != closingProviders.end())
                             continue;