Conditional Parsing values not being added to size

[AidanWelch]

Hi,

I have an array of values, of a type where they have conditional members. Unfortunately, the size seems to be computed only from the static properties. Is there a way around this?

In the example above collection is a conditional property.

[AidanWelch]

I think it may be because its a conditional union

[AidanWelch]

Yeah, condition union was the issue. I was able to resolve it by making it a struct then offsetting my other structs with $ -= 0x02;

[paxcut]

From what you posted the unions are the members, but the collection is a structure. the size of the union is the size of the largest element in the union. If the collection is part of the first union, then the size of the union should be 0xD and not 2. I have tested that with a simple example and it works.
the code

struct test {
   u32 array[5];
};

union test2 {
    u8 a;
    u8 b;
    test t;
};

test2 t2 @0;

and the result

[AidanWelch]

Except the size is not correct for conditional unions:

struct test {
   u32 array[5];
};

union test2 {
    u8 a;
    u8 b;
    if (a == b){
        test t;
    }
};

test2 t2 @0;

[paxcut]

I see. You marked your response as a solution but it just a work around and the bug needs to be fixed because unions should also calculate their sizes correctly. In order to narrow down the possible places where the bug is located you may want to mention unions in the title.

[AidanWelch]

This isn't a bug report though, I wasn't sure if I was misunderstanding what the intended effect is. I will open an issue to report it as an actual bug now that I know it is one.

[AidanWelch]

I opened #1504

[paxcut]

I saw that and it look very good. straight to the point and even provided simple code. I appreciate you taking the time to do this.

[AidanWelch]

Of course! I appreciate the effort to improve and maintain a tool that's been very helpful to me!