fix: Not being able to close certain modal popups with the close button on the title bar #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on on the title bar For example, closing the "Export pattern File" modal took several clicks on the "X" button, now it closes instantly. When the close button is clicked, `ImGui::BeginPopupModal()` sets the bool passed into the second parameter (p_open) to false. However, the closing logic did not take this into account, making it difficult to actually close modal popups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
When the close button is clicked,
ImGui::BeginPopupModal()sets the bool passed into the second parameter (p_open) to false. However, the closing logic did not take this into account, making it difficult to actually close modal popups.For example, closing the "Export pattern File" modal took several clicks on the "X" button, now it closes instantly.
Implementation description
I added an additional check for the
openvariable beingfalsein the logic that checks the closing condition.