Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: Add a link to the "Find" view in the search popup #1665

Merged
merged 3 commits into from
May 11, 2024

Conversation

SparkyTD
Copy link
Contributor

Problem description

This PR adds a shortcut link on the Search (Ctrl+F) popup to the more advanced "Find" view that is normally accessible at the View > Find menu.

Implementation description

I added a simple ImGuiExt::IconHyperlink link to the draw() function of the PopupFind class to display the hyperlink. Clicking the link will open the Find view, bring it into focus and close the current popup.

Screenshots

Before:
image

After:
image

Additional things

  • Localization keys were added to all .json files, but only en_US is populated for now.

@SparkyTD
Copy link
Contributor Author

Should I try to AI-translate the rest of the localizations before we merge?

@WerWolv
Copy link
Owner

WerWolv commented May 11, 2024

Thank you!

Should I try to AI-translate the rest of the localizations before we merge?

No, please only fill in the languages that you know yourself and leave the rest for dedicated translators that know the language. That way we can ensure that the translations actually are meaningful. I rather have a program with no translation for my native language than one with a comically wrong one ^^

@WerWolv WerWolv merged commit 09bffb6 into WerWolv:master May 11, 2024
@SparkyTD SparkyTD deleted the dev_advanced_search_link_2 branch May 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants