Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define each prop separately and remove & VariantProps<typeof styles> pattern from types #141

Closed
samithaf opened this issue Oct 16, 2023 · 0 comments
Closed

Define each prop separately and remove & VariantProps<typeof styles> pattern from types #141

samithaf opened this issue Oct 16, 2023 · 0 comments
Assignees
@tomjackking

Comments

@samithaf
Copy link
Collaborator

samithaf commented Oct 16, 2023 •
edited
Loading

We were simply combing types but it break the docs. Library author suggests to define the each prop separately

nextui-org/tailwind-variants#85
@samithaf samithaf changed the title Update the typings as per the suggestion https://github.com/nextui-org/tailwind-variants/discussions/85 Define each prop separately and remove & VariantProps<typeof styles> pattern from types Oct 16, 2023
@samithaf samithaf mentioned this issue Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomjackking tomjackking

Labels
None yet
Projects
GEL Tech Upgrade
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samithaf @tomjackking