Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: profilePictureUrl #901

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: profilePictureUrl #901

merged 1 commit into from
Jul 12, 2024

Conversation

zennn08
Copy link
Contributor

@zennn08 zennn08 commented Jul 3, 2024 •
edited
Loading

fix #900

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@zennn08/Baileys#profile-picture-url
# YARN v2
yarn add @whiskeysockets/baileys@zennn08/Baileys#profile-picture-url

@rayss868
Copy link

rayss868 commented Jul 3, 2024

Work

MrHoss
MrHoss approved these changes Jul 3, 2024
View reviewed changes
Copy link

@MrHoss MrHoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine

santosgalahack
santosgalahack approved these changes Jul 3, 2024
View reviewed changes
Copy link

@santosgalahack santosgalahack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@DavidsonGomes
Copy link
Contributor

Up

@lugialo
Copy link

lugialo commented Jul 3, 2024

up

brunocgc
brunocgc approved these changes Jul 3, 2024
View reviewed changes
Copy link

@brunocgc brunocgc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine

@jadersistemas
Copy link

imagem_2024-07-03_153959745
fail

@skyspablo
Copy link

The changes are working

@odeliojr
Copy link

odeliojr commented Jul 3, 2024

👍

@ainitech
Copy link

ainitech commented Jul 3, 2024

Working

1 similar comment
@IanosJunior
Copy link

Working

@jadersistemas
Copy link

image

em localhost ok na VPS nada!

@jreboredo
Copy link

Working

@pedrofarbo pedrofarbo mentioned this pull request Jul 4, 2024
Closed
@bergpinheiro
Copy link

Up

tpchagas
tpchagas approved these changes Jul 4, 2024
View reviewed changes
Copy link

@tpchagas tpchagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok approve funcional

@Its-me-nishmal
Copy link

nice , working well

@Its-me-nishmal Its-me-nishmal mentioned this pull request Jul 4, 2024
Closed
CSFelix
CSFelix approved these changes Jul 4, 2024
View reviewed changes
Copy link

@CSFelix CSFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@hudsonebert
Copy link

Funcionou.

deivisonrpg
deivisonrpg approved these changes Jul 4, 2024
View reviewed changes
Copy link

@deivisonrpg deivisonrpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

CSFelix
CSFelix approved these changes Jul 4, 2024
View reviewed changes
Copy link

@CSFelix CSFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on Windows!!

@GGTY81
Copy link

GGTY81 commented Jul 4, 2024

Work perfectly

bobslavtriev
bobslavtriev approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@bobslavtriev bobslavtriev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andresayac
andresayac approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@andresayac andresayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working

@w3nder

This comment was marked as abuse.

Sign in to view
@panalgin
Copy link

panalgin commented Jul 5, 2024

@PurpShell can you please review this

@lauriolasw lauriolasw mentioned this pull request Jul 6, 2024
Closed
@Rippanteq7 Rippanteq7 mentioned this pull request Jul 9, 2024
Closed
@skyspablo
Copy link

Let's release it 🙏

@PurpShell PurpShell merged commit 5bdfc63 into WhiskeySockets:master Jul 12, 2024
2 checks passed
@skyspablo
Copy link

@PurpShell any ETA on releasing the v 6.7.6 to NPM? 🙏🙏🙏

@Rippanteq7 Rippanteq7 mentioned this pull request Jul 21, 2024
Closed
Norldir added a commit to Norldir/Baileys that referenced this pull request Jul 22, 2024
@Norldir
Merge pull request #1 from WhiskeySockets/master
ae2eb94 
fix: profilePictureUrl (WhiskeySockets#901)
PurpShell added a commit that referenced this pull request Jul 27, 2024
@PurpShell @zennn08
@Rizz2Dev @oscarguindzberg @bobslavtriev
merge (#946)
a40fc9d 
* fix: profilePictureUrl (#901)

* Update module to latest version  (#926)

* Update package.json

Update the module to the latest

* Add files via upload

* Fix: Readme use upsert events (#908)

* Fix: getUSyncDevices (#862)

* Update messages-send.ts

* Update messages-send.ts

* Update messages-send.ts

* Fix lint

* Fix lint

* fix(master): update linting workflow to node 20 (current LTS)

---------

Co-authored-by: Akhlaqul Muhammad Fadwa <75623219+zennn08@users.noreply.github.com>
Co-authored-by: Rizz2Dev <muhamad.rizki27483@smp.belajar.id>
Co-authored-by: Oscar Guindzberg <oscar.guindzberg@gmail.com>
Co-authored-by: Bob <115008575+bobslavtriev@users.noreply.github.com>
PurpShell added a commit that referenced this pull request Aug 14, 2024
@PurpShell @zennn08
@Rizz2Dev @oscarguindzberg @bobslavtriev
PDO protocol (peer data operation): Get more history sync + better me…
1f9cfb1 
…ssage retry mechanism (#919)

* feat(feature/pdo-sync): initial commit

* feat(feature/pdo-sync): Moved to conventional send functions, exported, patched some errors

* fix(feature/pdo-sync): Linting and more bugsquatting

* chore(feature/pdo-sync): linting done

* feat/fix(feat/pdo-sync): Newsletter decrypt + ack

* merge (#946)

* fix: profilePictureUrl (#901)

* Update module to latest version  (#926)

* Update package.json

Update the module to the latest

* Add files via upload

* Fix: Readme use upsert events (#908)

* Fix: getUSyncDevices (#862)

* Update messages-send.ts

* Update messages-send.ts

* Update messages-send.ts

* Fix lint

* Fix lint

* fix(master): update linting workflow to node 20 (current LTS)

---------

Co-authored-by: Akhlaqul Muhammad Fadwa <75623219+zennn08@users.noreply.github.com>
Co-authored-by: Rizz2Dev <muhamad.rizki27483@smp.belajar.id>
Co-authored-by: Oscar Guindzberg <oscar.guindzberg@gmail.com>
Co-authored-by: Bob <115008575+bobslavtriev@users.noreply.github.com>

* chore(feature/pdo-sync): final linting

* fix(feature/pdo-sync): make replies optional

* feat(feat/pdo-sync): add <unavailable> handle

* feat(feature/pdo-sync): Fixed the issues with peer messages and implemented some more logic

* fix(feature/pdo-sync): Make progress optional

* fix(feature/pdo-sync): Nullify and defeat Message absent from node if it is resolved immediately

* feat(feature/pdo-sync): Export message absent from node and export PDO request ID with it

---------

Co-authored-by: Akhlaqul Muhammad Fadwa <75623219+zennn08@users.noreply.github.com>
Co-authored-by: Rizz2Dev <muhamad.rizki27483@smp.belajar.id>
Co-authored-by: Oscar Guindzberg <oscar.guindzberg@gmail.com>
Co-authored-by: Bob <115008575+bobslavtriev@users.noreply.github.com>
@wkarts wkarts mentioned this pull request Aug 16, 2024
Merged
@Rippanteq7 Rippanteq7 mentioned this pull request Aug 28, 2024
Open
@neglywalker neglywalker mentioned this pull request Sep 4, 2024
Open
jgsn13
jgsn13 reviewed Sep 12, 2024
View reviewed changes
Copy link

@jgsn13 jgsn13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Jhonatas56
Jhonatas56 reviewed Sep 12, 2024
View reviewed changes
Copy link

@Jhonatas56 Jhonatas56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!

@neglywalker neglywalker mentioned this pull request Sep 24, 2024
Open
jlucaso1 pushed a commit to jlucaso1/Baileys that referenced this pull request Sep 27, 2024
@PurpShell @zennn08
@Rizz2Dev @oscarguindzberg @bobslavtriev
merge (WhiskeySockets#946)
2e65f3f 
* fix: profilePictureUrl (WhiskeySockets#901)

* Update module to latest version  (WhiskeySockets#926)

* Update package.json

Update the module to the latest

* Add files via upload

* Fix: Readme use upsert events (WhiskeySockets#908)

* Fix: getUSyncDevices (WhiskeySockets#862)

* Update messages-send.ts

* Update messages-send.ts

* Update messages-send.ts

* Fix lint

* Fix lint

* fix(master): update linting workflow to node 20 (current LTS)

---------

Co-authored-by: Akhlaqul Muhammad Fadwa <75623219+zennn08@users.noreply.github.com>
Co-authored-by: Rizz2Dev <muhamad.rizki27483@smp.belajar.id>
Co-authored-by: Oscar Guindzberg <oscar.guindzberg@gmail.com>
Co-authored-by: Bob <115008575+bobslavtriev@users.noreply.github.com>
@AdiKhanOfficial
Copy link

For me that wasn't working then i tried to add

to: WABinary_1.S_WHATSAPP_NET,
instead of
to: S_WHATSAPP_NET,

so now its working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jhonatas56 Jhonatas56 Jhonatas56 left review comments

@jgsn13 jgsn13 jgsn13 left review comments

@devlikepro devlikepro devlikepro approved these changes

@manfe manfe manfe approved these changes

@jador-tanner jador-tanner jador-tanner approved these changes

@Vitorg96 Vitorg96 Vitorg96 approved these changes

@santosgalahack santosgalahack santosgalahack approved these changes

@Silvioerick Silvioerick Silvioerick approved these changes

@bobslavtriev bobslavtriev bobslavtriev approved these changes

@Rippanteq7 Rippanteq7 Rippanteq7 approved these changes

@4relial 4relial 4relial approved these changes

@tpchagas tpchagas tpchagas approved these changes

@rayss868 rayss868 rayss868 approved these changes

@MrHoss MrHoss MrHoss approved these changes

@ainitech ainitech ainitech approved these changes

@CSFelix CSFelix CSFelix approved these changes

@slntopp slntopp slntopp approved these changes

@salomaolisboa salomaolisboa salomaolisboa approved these changes

@DavidsonGomes DavidsonGomes DavidsonGomes approved these changes

@andresayac andresayac andresayac approved these changes

@panalgin panalgin panalgin approved these changes

@ibinetwork ibinetwork ibinetwork approved these changes

@allgood allgood allgood approved these changes

@skyspablo skyspablo skyspablo approved these changes

@AlvaroBrasilia AlvaroBrasilia AlvaroBrasilia approved these changes

@brunocgc brunocgc brunocgc approved these changes

@deivisonrpg deivisonrpg deivisonrpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] reason: Error: bad-request client.profilePictureUrl()