Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: workdir control #102

Closed
wants to merge 273 commits into from
Closed

Conversation

ohaiibuzzle
Copy link
Member

@ohaiibuzzle ohaiibuzzle commented Jun 13, 2023

Allow users to control the working directory of a given application with the "smart" option of selecting the binary's directory (most of the time correct)

IsaacMarovitz and others added 21 commits June 9, 2023 12:21
* init Chinese localizable.strings

* update Chinese version

* fix

* update xcodeproj

* update zh-Hant

* add Drag and drop prompt as a localizable string

* fix empty line

* recover project.pbxproj
* Add German translation

* Fix German translation
* feat: add Ukrainian localization

* Add Project file changes
add korean

Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
* New translations Localizable.strings (French)

* New translations Localizable.strings (Polish)

* New translations Localizable.strings (French)

* New translations Localizable.strings (Spanish)

* New translations Localizable.strings (Russian)

* Update source file Localizable.strings

* New translations Localizable.strings (Chinese Simplified)

* New translations Localizable.strings (Chinese Traditional)

* New translations Localizable.strings (French)

* New translations Localizable.strings (Chinese Simplified)

* New translations Localizable.strings (Chinese Traditional)

* New translations Localizable.strings (Chinese Simplified)

* New translations Localizable.strings (Chinese Traditional)

* New translations Localizable.strings (German)

* New translations Localizable.strings (Ukrainian)

* New translations Localizable.strings (Spanish)

* New translations Localizable.strings (Spanish)

* New translations Localizable.strings (Finnish)

* New translations Localizable.strings (Korean)
Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
* New translations Localizable.strings (Russian)

* New translations Localizable.strings (Korean)

* New translations Localizable.strings (Dutch)

* New translations Localizable.strings (Italian)
* Added Turkish, Portuguese, Chinese, Japanese localizations and improved German localizations

* Remove CN and German changes

* Add to Xcode

---------

Co-authored-by: Peek-a-Chuu <k@s-MacBook-Pro.fritz.box>
Co-authored-by: Isaac Marovitz <isaacryu@icloud.com>
Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
* Add bottle name validation

* Change view to original size

* Fix line length violation

* Replace NSLocalizedString usage

* Change warning text position

* Invert name validation logic

* Rewrite return message, as enum flags

* Update Localizable.strings

---------

Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
@alexsch01
Copy link
Contributor

alexsch01 commented Jun 19, 2023

What happened to this pull request and the following? @IsaacMarovitz

#13
#27
#31
#92
#102 [this one]
#109
#110
#113
#114

(these were closed and the changes are not in main branch as far as I can see)

@IsaacMarovitz
Copy link
Member

What happened to this pull request and the following? @IsaacMarovitz

I had to do a massive and messy force push to get rid of LFS data in the repo. As a result, GitHub closed all current PRs as the commit history technically got out of sync.

@alexsch01
Copy link
Contributor

Ok, dang. Yeah the PRs I listed above should be about it for those affected

@IsaacMarovitz
Copy link
Member

Ok, dang. Yeah the PRs I listed above should be about it for those affected

Fixed up/merged #27, #113, and #114

@JoshuaBrest
Copy link
Contributor

What happened to this pull request and the following? @IsaacMarovitz

I had to do a massive and messy force push to get rid of LFS data in the repo. As a result, GitHub closed all current PRs as the commit history technically got out of sync.

ahhhhh

@ohaiibuzzle ohaiibuzzle deleted the feat/workdir branch September 9, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.