no need to check active state when handling or stopping updates

WickyNilliams · Oct 4, 2016 · 85dcf86 · 85dcf86
1 parent 102432c
commit 85dcf86
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/src/components/DraggableMixin.js b/src/components/DraggableMixin.js
@@ -47,24 +47,20 @@ const DraggableMixin = {
   },
 
   handleUpdate(e) {
-    if (this.state.active) {
-      e.preventDefault();
-      const { x, y } = this.getPosition(e);
-      this.updatePosition(this.rect, x, y);
-    }
+    e.preventDefault();
+    const { x, y } = this.getPosition(e);
+    this.updatePosition(this.rect, x, y);
   },
 
   stopUpdates() {
-    if(this.state.active) {
-      const { document } = this;
+    const { document } = this;
 
-      document.removeEventListener("mousemove", this.handleUpdate);
-      document.removeEventListener("touchmove", this.handleUpdate);
-      document.removeEventListener("mouseup", this.stopUpdates);
-      document.removeEventListener("touchend", this.stopUpdates);
+    document.removeEventListener("mousemove", this.handleUpdate);
+    document.removeEventListener("touchmove", this.handleUpdate);
+    document.removeEventListener("mouseup", this.stopUpdates);
+    document.removeEventListener("touchend", this.stopUpdates);
 
-      this.setState({ active : false });
-    }
+    this.setState({ active : false });
   },
 
   getPosition(e) {