Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrowthExperiments extension derails display of data on WikiApiary for wikis using it #22

Open
kghbln opened this issue Mar 15, 2021 · 1 comment · Fixed by #23
Open
Labels

Comments

@kghbln
Copy link
Member

kghbln commented Mar 15, 2021

The GrowthExperiments extension, at least I think this is the one causing the issue derails the display of data on WikiApiary because it returns data for pageviewservice-supported-metrics in complex JSON (not sure how to call this), i.e. the value fetched from the API closes with two brackets }} which conflicts with wikitext. The template thinks it comes to an end with the pageviewservice-supported-metrics parameter, which is obviously not the case.

..
|pageviewservice-supported-metrics={u'siteviews': {u'uniques': u'', u'pageviews': u''}, u'mostviewed': {u'pageviews': u''}, u'pageviews': {u'pageviews': u''}}
..

@hexmode Is there a way to tell BumbleBee to either escape the closing brackets or if easier to not even collect this data item? A fix will be cool to get WMF wikis on track again on WikiApiary.

@lens0021
Copy link
Contributor

Based on recent edits by bumble-bee, my patch doesn't seem to fix this issue; Maybe it is because x['pageviewservice-supported-metrics'] is an object, not basestring which is checked at line

if isinstance(value, basestring):
.

Could you reopen this? @hexmode

@hexmode hexmode reopened this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants