-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix styling on <select> elements #2263
Comments
I would love to work on this! Could you please point me in the right direction? @ragesoss |
It was supposed to be @shivanshbindal9 if you're already familiar with React, the outline of this task is something like:
|
Looks like the jest test for that will need to be updated. |
Sure! Send me an email to sage at wikiedu.org. |
#2410 addresses the issue that first option was selected even if any other option was selected. |
@shivanshbindal9 I think pretty much everywhere that uses Many of the cases we have left are for table sorting, like in UploadsHandler, RevisionsHandler, ArticlesHandler, and AlertsHandler. Others are more similar the ones you already did: CourseLevelSelector, HomeWikiLanguageSelector, and BlockTypeSelect. |
#2413 add react-select in home_wiki_language_selector. |
#2424 add react-select in block_type_selector. |
@ragesoss can i work on this? |
@shivanshbindal9 eventually, yes, we'll need to replace all uses of componentWillMount. If it's part of the same component that you're updating for @Arpitpundir maybe better to work on a different issue, as Shivansh is working through the select elements already. |
@ragesoss I am not able to select the course level when creating a new course. Can you please help !! |
To get that selector, you need to have |
#2430 add react-select in course_level_selector !! |
@ragesoss Sir, are there still any |
@ragesoss sir, sorry for not working on this for a long time as I had my university exams. Actually, when I am trying to use |
@shivanshbindal9 interesting. It might not be possible with that library, I guess? I suggest opening an issue at react-select to describe what you're trying to do and ask if there's a way. If not, it's not a big deal; the sort selector is the least noticable. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Can I work on this issue?? |
@Priyanshu-su30 sure, give it a try. A good way to begin might be to identify remaining |
@ragesoss can u provide me the slack link I can't find it |
@Priyanshu-su30 let me know your email address and I can send you an invite. |
@ragesoss Sure my email address is: |
Using native
<select>
elements, as we do on many forms, makes it difficult to style the inputs. In particular, the dropdowns use the native browser / OS styling that can't be changed with CSS.Where we use the
react-select
library, we have control over the styling, like this:But for native elements, we get colors that don't match the rest of the system:
Probably the easiest solution will be to replace uses of plain
<select>
withreact-select
components.The text was updated successfully, but these errors were encountered: