-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert InputMixin to a high-order Component #1775
Convert InputMixin to a high-order Component #1775
Conversation
@ragesoss I separated the |
@ragesoss Is the failing Travis build a random failure? I don't think I made any changes to CourseCloneModal. If it is a random failure, can you please restart the Travis build. |
Will do. Can you confirm that that spec passes locally? It does some unique things in terms of state, inputs, and validations, and this one is not one that I've seen fail randomly in a long while. |
@psinghal20 same spec failed again. It's probably a real failure. |
Have you tried checking which input components use |
@ragesoss The specs seems to fail when the same course term is used as the original course, but in my local branch, the failure message does appear when the course term is same as the original course. When I try to run this spec on my local branch, the test fails and raises the error |
I take it that course cloning works as expected when you do it manually? Putting in the same term as the original will show the error message and let you change them term and proceed? |
That uses Capybara's |
Yes, it does behave as expected when I try it manually but I don't know why the local spec makes my PhantomJS client die. |
Okay. I'll poke at it next week. |
@ragesoss Found what was causing my local failure, it was because of console statement I added to debug. Removed and ran all the feature specs. All specs pass on my local build. |
Fixes #1456.
It replaces the
InputMixin
withInputHOC
component which is then used with several input fields to validate entries by using validation entries.