Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditionally rendered link issue#2546 #2641

Merged
merged 3 commits into from Mar 25, 2019
Merged

conditionally rendered link issue#2546 #2641

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f441e28
conditionally rendered link
hjhimanshu01 Mar 17, 2019
d0f00f1
mistake
hjhimanshu01 Mar 18, 2019
159b27c
corrected changes
hjhimanshu01 Mar 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/assets/javascripts/components/common/article_viewer.jsx
View file
Open in desktop
Expand Up @@ -328,7 +328,9 @@ const ArticleViewer = createReactClass({
<div className="article-header">
<p>
<span className="article-viewer-title">{trunc(this.props.article.title, 56)}</span>
<span><a className="icon-link" href={`?showArticle=${this.props.article.id}`} /></span>
{!this.props.article.id && (
<span><a className="icon-link" href={`?showArticle=${this.props.article.id}`} /></span>
) }
{closeButton}
<a className="button small pull-right article-viewer-button" href={`/feedback?subject=Article Viewer — ${this.props.article.title}`} target="_blank">How did the article viewer work for you?</a>
</p>
Expand Down