Converting Nav and HamburgerMenu into functional components #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to #5393
What this PR does
Converts
nav.jsxandhamburger_menu.jsxinto functional componentsAffected Pages:
Videos
Before
intro.jsxandhamburger_menu.jsxbefore.refactor.Nav.and.HamburgerMenu.mp4
After
intro.jsxandhamburger_menu.jsxafter.refactor.Nav.and.HamburgerMenu.mp4
Clarifications
I made some changes to the code structure for both files, initially, we had a large amount of conditionals that would assign jsx elements into a variable, then that variable would be placed later on in the render method. This caused a lot of 'one-time use' variables. I decided to put all the conditionals inside the renders directly without the use of variables. This makes the code a lot easier to read.