Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting Nav and HamburgerMenu into functional components #5456

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Converting Nav and HamburgerMenu into functional components #5456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dfda69
Converted Nav into functional component + Improved code readability a…
Aminehassou Jul 17, 2023
3fc6a87
Converted HamburgerMenu into functional component + code structure cl…
Aminehassou Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
263 changes: 109 additions & 154 deletions app/assets/javascripts/components/nav/hamburger_menu.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,170 +1,125 @@
import React from 'react';
import createReactClass from 'create-react-class';
import React, { useState } from 'react';
import PropTypes from 'prop-types';
import CustomLink from './CustomLink.jsx';
import LanguagePicker from './language_picker.jsx';

const HamburgerMenu = createReactClass({
displayName: 'HamburgerMenu',
const HamburgerMenu = ({ rootUrl, logoPath, exploreUrl, exploreName, userSignedIn, ifAdmin, trainingUrl,
helpDisabled, wikiEd, languageSwitcherEnabled, currentUser, destroyUrl, omniauthUrl }) => {
const [isActive, setIsActive] = useState(false);

propTypes: {
rootUrl: PropTypes.string,
logoPath: PropTypes.string,
exploreUrl: PropTypes.string,
exploreName: PropTypes.string,
userSignedIn: PropTypes.bool,
ifAdmin: PropTypes.bool,
trainingUrl: PropTypes.string,
helpDisabled: PropTypes.bool,
wikiEd: PropTypes.bool,
languageSwitcherEnabled: PropTypes.bool,
currentUser: PropTypes.string,
destroyUrl: PropTypes.string,
omniauthUrl: PropTypes.string
},
const toggleClass = () => {
setIsActive(!isActive);
};

getInitialState() {
return this.getState();
},

getState() {
return {
isActive: false
};
},

toggleClass() {
this.setState({ isActive: !this.state.isActive });
},

render() {
const { rootUrl, logoPath, exploreUrl, exploreName, userSignedIn, ifAdmin, trainingUrl, helpDisabled, wikiEd, languageSwitcherEnabled, currentUser, destroyUrl, omniauthUrl } = this.props;
let myDashboard;
let forAdmin;
let help;
let programsDashboard;
let languageSwitcher;
let loginLinks;
let helpEnabled;
if (languageSwitcherEnabled) {
languageSwitcher = (
<LanguagePicker />
);
}
if (userSignedIn) {
loginLinks = (
<span>
<li>
<b><a href={rootUrl} className="current-user">{currentUser}</a></b>
</li>
<li>
<a href={destroyUrl} className="current-user">{I18n.t('application.log_out')}</a>
</li>
</span>
);
if (!helpDisabled) {
helpEnabled = (
<li>
<form className="top-nav__faq-search" target="_blank" action="/faq" acceptCharset="UTF-8" method="get">
<input name="utf8" type="hidden" defaultValue="✓" />
<input type="text" name="search" id="hamburger_search" defaultValue="" placeholder={I18n.t('application.search')} />
<input name="source" type="hidden" defaultValue="nav_ask_form" />
<button type="submit">
<i className="icon icon-search" />
</button>
</form>
</li>
);
}
} else {
// This link relies on rails/ujs to turn the anchor link into
// a POST request based on data-method="post". Otherwise, this
// needs to become a button or form and include the authenticity token.
loginLinks = (
<li>
<a data-method="post" href={omniauthUrl}>
<i className="icon icon-wiki-logo" />
{I18n.t('application.log_in')}
<span className="expand">
&nbsp;{I18n.t('application.sign_up_log_in_extended')}
</span>
</a>
</li>
);
}
if (userSignedIn === true) {
myDashboard = (
<li>
<CustomLink to={rootUrl} name={I18n.t('application.my_dashboard')} clickedElement="" />
</li>
);
}
if (ifAdmin === true) {
forAdmin = (
<li>
<CustomLink to="/admin" name="Admin" />
</li>
);
}
if ((userSignedIn || helpDisabled) === false) {
help = (
<li>
<CustomLink to="/faq" name={I18n.t('application.help')} />
</li>
);
}
if (!wikiEd) {
programsDashboard = (
<span id="span_wikied">
<li>
<CustomLink to="https://meta.wikimedia.org/wiki/Programs_%26_Events_Dashboard" name={I18n.t('application.documentation')} target="_blank" />
</li>
<li>
<CustomLink to="/feedback" name={I18n.t('application.report_problem')} target="_blank" />
</li>
</span>
);
}
return (
<div>
<nav className="ham-nav">
<div className="container">
<div className="ham-nav__site-logo">
<a className="logo__link" href= {rootUrl}>
<img src ={logoPath} alt = "wiki logo" />
</a>
</div>
{languageSwitcher}
<div className="hamburger_menu_wrapper">
<div className ="bm-burger-button" onClick={this.toggleClass}>
<div className ={(this.state.isActive) ? 'bm-menu-active' : ''}>
<div className = "bar1" />
<div className = "bar2" />
<div className = "bar3" />
</div>
return (
<div>
<nav className="ham-nav">
<div className="container">
<div className="ham-nav__site-logo">
<a className="logo__link" href={rootUrl}>
<img src={logoPath} alt="wiki logo" />
</a>
</div>
{languageSwitcherEnabled && <LanguagePicker />}
<div className="hamburger_menu_wrapper">
<div className="bm-burger-button" onClick={toggleClass}>
<div className={(isActive) ? 'bm-menu-active' : ''}>
<div className="bar1" />
<div className="bar2" />
<div className="bar3" />
</div>
<div className = {`bm-menu-wrap ${(this.state.isActive) ? 'bm-menu-visible' : ''}`}>
<div className= "bm-menu">
</div>
<div className={`bm-menu-wrap ${(isActive) ? 'bm-menu-visible' : ''}`}>
<div className="bm-menu">
<li>
<CustomLink to={exploreUrl} name={exploreName} clickedElement="explore" />
</li>
{userSignedIn && (
<li>
<CustomLink to={exploreUrl} name={exploreName} clickedElement="explore" />
<CustomLink to={rootUrl} name={I18n.t('application.my_dashboard')} clickedElement="" />
</li>
{myDashboard}
{forAdmin}
)}
{ifAdmin && (
<li>
<CustomLink to={trainingUrl} name={I18n.t('application.training')} clickedElement="training" />
<CustomLink to="/admin" name="Admin" />
</li>
{help}
{programsDashboard}
{helpEnabled}
{loginLinks}
</div>
)}
<li>
<CustomLink to={trainingUrl} name={I18n.t('application.training')} clickedElement="training" />
</li>
{((userSignedIn || helpDisabled) === false) && (
<li>
<CustomLink to="/faq" name={I18n.t('application.help')} />
</li>
)}
{!wikiEd && (
<span id="span_wikied">
<li>
<CustomLink to="https://meta.wikimedia.org/wiki/Programs_%26_Events_Dashboard" name={I18n.t('application.documentation')} target="_blank" />
</li>
<li>
<CustomLink to="/feedback" name={I18n.t('application.report_problem')} target="_blank" />
</li>
</span>
)}
{userSignedIn && !helpDisabled && (
<li>
<form className="top-nav__faq-search" target="_blank" action="/faq" acceptCharset="UTF-8" method="get">
<input name="utf8" type="hidden" defaultValue="✓" />
<input type="text" name="search" id="hamburger_search" defaultValue="" placeholder={I18n.t('application.search')} />
<input name="source" type="hidden" defaultValue="nav_ask_form" />
<button type="submit">
<i className="icon icon-search" />
</button>
</form>
</li>
)}
{userSignedIn ? (
<span>
<li>
<b><a href={rootUrl} className="current-user">{currentUser}</a></b>
</li>
<li>
<a href={destroyUrl} className="current-user">{I18n.t('application.log_out')}</a>
</li>
</span>
) : (
// This link relies on rails/ujs to turn the anchor link into
// a POST request based on data-method="post". Otherwise, this
// needs to become a button or form and include the authenticity token.
<li>
<a data-method="post" href={omniauthUrl}>
<i className="icon icon-wiki-logo" />
{I18n.t('application.log_in')}
<span className="expand">
&nbsp;{I18n.t('application.sign_up_log_in_extended')}
</span>
</a>
</li>
)}
</div>
</div>
</div>
</nav>
</div>
);
}
});
</div>
</nav>
</div>
);
};

HamburgerMenu.propTypes = {
rootUrl: PropTypes.string,
logoPath: PropTypes.string,
exploreUrl: PropTypes.string,
exploreName: PropTypes.string,
userSignedIn: PropTypes.bool,
ifAdmin: PropTypes.bool,
trainingUrl: PropTypes.string,
helpDisabled: PropTypes.bool,
wikiEd: PropTypes.bool,
languageSwitcherEnabled: PropTypes.bool,
currentUser: PropTypes.string,
destroyUrl: PropTypes.string,
omniauthUrl: PropTypes.string,
};

export default HamburgerMenu;