Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

SUS-2050 | CategoryViewer: use CategoryRefreshCountsTask #12959

Merged
merged 3 commits into from
May 23, 2017

Conversation

macbre
Copy link
Contributor

@macbre macbre commented May 22, 2017

https://wikia-inc.atlassian.net/browse/SUS-2050

Move heavy queries (and prone to database deadlocks) from Category::refreshCounts to an offline task.

@WikiaTech
Copy link

SonarQube analysis reported 25 issues

  • MAJOR 13 major
  • MINOR 5 minor
  • INFO 7 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Category.php#L30: Reduce the number of returns of this function 4, down to the maximum allowed 3. rule
  2. MAJOR Category.php#L191: Add curly braces around the nested statement(s). rule
  3. MAJOR Category.php#L256: Merge this if statement with the enclosing one. rule
  4. MAJOR CategoryViewer.php#L3: Add curly braces around the nested statement(s). rule
  5. MAJOR CategoryViewer.php#L6: Class "CategoryViewer" has 24 methods, which is greater than 20 authorized. Split it into smaller classes. rule
  6. MAJOR CategoryViewer.php#L100: Take the required action to fix the issue indicated by this "FIXME" comment. rule
  7. MAJOR CategoryViewer.php#L112: Replace this legacy wfMsg* function call with one of the new i18n functions. rule
  8. MAJOR CategoryViewer.php#L321: Extract this increment or decrement operator into a dedicated statement. rule
  9. MAJOR CategoryViewer.php#L378: Replace this legacy wfMsg* function call with one of the new i18n functions. rule
  10. MAJOR CategoryViewer.php#L396: Take the required action to fix the issue indicated by this "FIXME" comment. rule

@macbre macbre merged commit 6f562da into dev May 23, 2017
@macbre macbre deleted the SUS-2050-task-for-category-refreshCount branch May 23, 2017 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants