This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
SUS-2161: Create background task for user watchlist updates #12993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszabo-wikia
changed the title
|
SonarQube analysis reported 95 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
WikiaTech
reviewed
May 26, 2017
| @@ -2920,19 +2920,28 @@ public function removeWatch( $title ) { | |||
| * the next change of the page if it's watched etc. | |||
| * @param $title Title of the article to look at | |||
| */ | |||
| public function clearNotification( &$title ) { | |||
| global $wgUseEnotif, $wgShowUpdatedMarker; | |||
| public function clearNotification( Title $title ) { | |||
There was a problem hiding this comment.
ghost
removed request for
ghost
approved these changes
May 29, 2017
macbre
approved these changes
May 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wikia-inc.atlassian.net/browse/SUS-2161
Created a background task to handle watchlist and talk page notifications asynchronously, and removed the unused WatchSubPages extension.