Categoryselect refactor #284

kflorence · 2012-12-20T21:33:41Z

This is a rather large commit, so here are the gist of the changes:

JavaScript code 100% rewritten. It is no longer dependent on YUI and has a much smaller footprint.
The extension has been refactored from one large file into several distinct files.
AJAX methods now live in a Nirvana controller.
Hooks have been consolidated and removed where possible with the remaining hooks living in a HooksHelper class.
HTML has been broken out into templates instead of being inlined in PHP.
i18n has been cleaned up, unused messages were removed, some new messages were added and some names were changed for better clarity. All of the messages have documentation.
Styles have been moved into Sass files and have been split across article and edit pages.
The article page category select module has been re-styled.

… making CategorySelect into a controller.

Split hooks into CategorySelectHooksHelper class, split html into templates, created CategorySelectController to handle requests.

… Hooks helper.

…ames.

…e, also set up skeleton for the other functions.

Remove the 'source mode' requirements of maintaining a wikitext data structure. Use the same UI and underlying data structures for both visual and source modes (BugId:48693)."

Added JavaScript logic for adding categories. Made the behavior of accessing categories more consistent. Moved the normalizing category function into the CategorySelect class.

Also create getExtractedCategoryData as a getter instead of trying to use getData as a multipurposed function (it's more explicit this way).

…change summary Conflicts: extensions/wikia/EditPageLayout/js/editor/WikiaEditorStorage.js

…ySelectStateOnLogin Bugid 95455 wikia editor save category select state on login

Conflicts: extensions/wikia/CategorySelect/CategorySelect.i18n.php extensions/wikia/Development/Configs_DevBox/LocalSettings.php extensions/wikia/EditPageLayout/js/editor/WikiaEditorStorage.js

…verification.

…mplate and into controller.

Fix Sizzle exceptions for invalid expressions when trying to match against strings in getCategories. Always uppercase the first letter of a category to properly match Mediawiki titles.

kflorence · 2013-01-25T01:09:49Z

Alright, I think this is good to go. Going to get a design / product check then we'll see about the merge.

…e dropdown.

…PiotrGackowski

…PiotrGackowski).

Categoryselect refactor

kflorence added 30 commits November 16, 2012 21:17

CategorySelect: re-organize the extension directory in preperation of…

89f0870

… making CategorySelect into a controller.

CategorySelect: continued re-organization.

3608843

Split hooks into CategorySelectHooksHelper class, split html into templates, created CategorySelectController to handle requests.

CategorySelect: register all required classes. Fix parse error in the…

3dcbd43

… Hooks helper.

CategorySelect: fix typo in conditional.

8307799

CategorySelect: add missing hook onGetPreferences. Alphabetize hook n…

6cb0778

…ames.

CategorySelect: fix url to the stylesheet file.

3eb45fa

CategorySelect: clean up EditPageLayout module and start on refactoring.

c47f3ae

CategorySelect: begin JavaScript and Stylesheet refactoring.

fb7ba5d

CategorySelect: change 'category' key to 'name'; some minor cleanup.

6cd0007

CategorySelect: update edit page metadata template to add data type.

5a2def5

CategorySelect: implement addCategory for edit page visual editor mod…

8501c11

…e, also set up skeleton for the other functions.

CategorySelect: update Categories module to work with new code.

11badaa

Always use JSON as the data structure.

b59296f

Remove the 'source mode' requirements of maintaining a wikitext data structure. Use the same UI and underlying data structures for both visual and source modes (BugId:48693)."

Add the ability to add categories on edit pages.

09adc08

Added JavaScript logic for adding categories. Made the behavior of accessing categories more consistent. Moved the normalizing category function into the CategorySelect class.

Rename getData -> extractCategoriesFromWikitext.

a18e747

Also create getExtractedCategoryData as a getter instead of trying to use getData as a multipurposed function (it's more explicit this way).

Remove underscores from Sass files. Remove YUI-suggest styles.

90bdbd0

Make epl inputs mixin self-sustaining.

19a1313

Make CategorySelect less ugly.

09d6a90

Make jquery.ui.autocomplete file self-sustainable.

7bb332d

Add width for suggest dropdown

063a0b0

Fix event binding

bc69a6a

Fix EditPageLayout styles (needed multiple-box-shadow mixin).

5e0ef06

Add JSMessages support.

489c4c5

Finish category list for edit pages.

785821f

Implement removeCategory.

333d153

Rename 'listItem' to 'category' -- more explicit.

6324343

Implement category editing.

76414e3

Small tweaks to category list.

d1a70e6

Category name ellipsis tweaks.

65cef65

Set up files for view and edit modes.

34110b4

macbre and others added 21 commits January 17, 2013 13:21

Memcache config for Poznań devboxes

12e251d

bugid-23457 | Added chacking if editor is dirty and trigger dirty os …

2455273

…change summary Conflicts: extensions/wikia/EditPageLayout/js/editor/WikiaEditorStorage.js

bugid-95741 | WikiaEditor - Category select marks editor as dirty

0e9fdbb

bugid-95455 | WikiaEditorStorage changed undefined checking

02b676c

bugid-95455 | WikiaEditorStorage changed undefined checking

2ab4d7d

Merge pull request #364 from Wikia/bugid-95455_WikiaEditorSaveCategor…

b09bf37

…ySelectStateOnLogin Bugid 95455 wikia editor save category select state on login

Merge branch 'dev' into categoryselect-refactor

532f6c6

Conflicts: extensions/wikia/CategorySelect/CategorySelect.i18n.php extensions/wikia/Development/Configs_DevBox/LocalSettings.php extensions/wikia/EditPageLayout/js/editor/WikiaEditorStorage.js

CategorySelect: prevent duplicate categories.

3df2026

CategorySelect: lazy load article categories for front-end duplicate …

e8959be

…verification.

CategorySelect: update article page styles. Move some logic out of te…

731f513

…mplate and into controller.

Popover hint for adding categories.

5fc74ab

Fix Sizzle exceptions for invalid expressions when trying to match against strings in getCategories. Always uppercase the first letter of a category to properly match Mediawiki titles.

Implement add category button and popover hint for article pages.

efb162b

Fix preserving the order in which categories are added.

5a767ad

Add i18n for add category popover hint.

1e06592

Restyle article page according to new design specs.

928255d

Fix popover hint key.

8be8ee8

Trim category names.

c1bfa09

Normalize category names before removing duplicates.

0048d84

Add new categories data to response of save function.

e920468

Remove duplicated categories from DOM on save.

2f678d8

Merge branch 'dev' into categoryselect-refactor

44bdf2c

Kyle Florence added 5 commits January 25, 2013 01:25

Remove right border for last category.

2a483e8

Early exit for users who can't edit.

f1ff649

Add ui-state-hover background color for selected items in autocomplet…

1ae0b12

…e dropdown.

Implement maximum character limit of 255 for category names (thanks @…

c7f9a1f

…PiotrGackowski).

Use keydown instead of keypress for max length checking.

d4ca4c4

kflorence added a commit that referenced this pull request Jan 28, 2013

Merge pull request #284 from Wikia/categoryselect-refactor

ec4fc08

Categoryselect refactor

kflorence merged commit ec4fc08 into dev Jan 28, 2013

kflorence deleted the categoryselect-refactor branch January 28, 2013 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Categoryselect refactor #284

Categoryselect refactor #284

kflorence commented Dec 20, 2012

kflorence commented Jan 25, 2013

Categoryselect refactor #284

Categoryselect refactor #284

Conversation

kflorence commented Dec 20, 2012

kflorence commented Jan 25, 2013