Call clause

[transistive]

I added support for the CALL clause for sub queries.

It's just a Clause accepting another query to build the subject with.

I also added a method on the Query object which uses a callable accepting a fresh query so the user can create something like this:

$node = Query::node('X')->named('y');
$query = Query::new()->match($node)
        ->call(function (Query $subQuery) use ($node) {
            $subQuery->with($node->getVariable())
                ->where($node->property('z')->equals(Query::literal('foo'), false))
                ->returning($node->property('z')->alias('foo'));
        })
        ->returning(Query::variable('foo'));

$this->assertEquals("MATCH (y:X) CALL { WITH y WHERE y.z = 'foo' RETURN y.z AS foo } RETURN foo", $query->toQuery());

[transistive]

Partly solves issue #28

[marijnvanwezel]

I like the decorator approach, but I would also like the Query::call function to be able to accept a class of type Query directly.

[transistive]

Nice, Can I add it to the github ci? Otherwise, I will keep forgetting. It will automatically block merges if the rules aren't met

…

------- Original Message -------

On Monday, April 25th, 2022 at 4:44 PM, wgevaert ***@***.***> wrote: @wgevaert commented on this pull request. --------------------------------------------------------------- In [src/Query.php](#40 (comment)): > @@ -21,6 +21,9 @@ namespace WikibaseSolutions\CypherDSL; +use Closure; +use Prophecy\Call\Call; In case you are interested, I usually run it like path/to/vendor/bin/php-cs-fixer fix ***@***.***,align_multiline_comment,array_indentation,blank_line_before_statement,indentation_type,no_trailing_whitespace,no_unused_imports,no_useless_else,no_useless_return,ordered_imports,phpdoc_scalar,return_assignment,simplified_if_return,single_line_after_imports,switch_case_space,trailing_comma_in_multiline,ternary_operator_spaces ./src or something along these lines. Fixes most codestyle issues I usually make. Personally I also like the operator_linebreak and single_quote rules but I won't enforce those on this package. And there's also a bunch of nice risky fixes that are worth checking out. — Reply to this email directly, [view it on GitHub](#40 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AD5MVWXC4N2DENFNAT27EUDVG2VVNANCNFSM5UGUTEJA). You are receiving this because you authored the thread.Message ID: ***@***.***>

[wgevaert]

I'm okay with adding it to the github ci, I don't know how to do that haha.

Concerning this pull request, note that CYPHER also allows for CALL procedures of the form CALL some.procedure() YIELD somestuff WHERE something RETURN stuff. Do you have any suggestions for how to go about implementing that in the future, when this will be implemented as suggested in this pull request?

(ofc we do not have to think about that right now, but we could).

[wgevaert]

Looks good to me

[marijnvanwezel]

OK.