Only get suggestions once when the input field is initially focused (#…

…175)

Right now the suggestions are loaded whenever the field is empty
and it gets the focus. That's not needed, because old results are
retained anyway, thus we only ever need to get the suggestions
once. (If it gets refocused it displays the old suggestions again.)

This will save us quite some API requests and also will it save us
from race conditions when two such api requests are returning.

https://phabricator.wikimedia.org/T143645

.gitignore

@@ -0,0 +1 @@
+vendor/

README.md

@@ -45,6 +45,9 @@ generate this data from a wikidata dump.
 
 ## Release notes
 
+### 3.1.3 (dev)
+* Only get suggestions once when the property input field is initially focused.
+
 ### 3.1.2 (2016-08-04)
 * Follow up fix for entity suggester, update cache management in EntitySuggester.
 

modules/ext.PropertySuggester.EntitySelector.js

@@ -42,7 +42,10 @@
 				}
 			};
 
-			this.element.on( 'focus', focusHandler );
+			// Search for suggestions once the field is initially focused.
+			// We only need to do this once, afterwards the old suggestions
+			// will re-appear on focus anyway.
+			this.element.one( 'focus', focusHandler );
 		},
 
 		/**