Only get suggestions once when the input field is initially focused #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the suggestions are loaded whenever the field is empty and it gets the focus. That's not needed, because old results are retained anyway, thus we only ever need to get the suggestions once. (If it gets refocused it displays the old suggestions again.) This will save us quite some API requests and also will it save us from race conditions when two such api requests are returning. https://phabricator.wikimedia.org/T143645
|
Makes sense. Thanks a lot for this and a billion other awesome fixes you are doing all over our code bases! I would like to test this manually before merging it. |
|
Confirmed via live-hacking in Chrome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the suggestions are loaded whenever the field is empty
and it gets the focus. That's not needed, because old results are
retained anyway, thus we only ever need to get the suggestions
once. (If it gets refocused it displays the old suggestions again.)
This will save us quite some API requests and also will it save us
from race conditions when two such api requests are returning.
https://phabricator.wikimedia.org/T143645