Suggestions for empty items #119
Conversation
There used to be (?) suggestions (e.g. P31) for items with no statements yet. This provides suggestions by item when there are no property ids used yet on the item, suggesting overall most used properties like P31 that users may want to start with on an empty item.
| @@ -68,7 +68,7 @@ public function testSuggestByPropertyIds() { | |||
| } | |||
|
|
|||
| public function testSuggestByItem() { | |||
| $item = Item::newEmpty(); | |||
| $item = new Item(); | |||
| $item->setId( new ItemId( 'Q42' ) ); | |||
There was a problem hiding this comment.
Please avoid calling setIt, use new Item( new ItemId( ... ) ).
There was a problem hiding this comment.
done, though not going to touch more of this code. should be a separate task to update code for new data model stuff.
|
I think the suggestions for empty objects were not merged? #87 this PR is still open. As far as I remember Lydia wanted to wait with it until the qualifier/refrence suggestion part was deployed but it wasn't merged afterwards. |
|
@xchrdw I missed that pull request... I think yours is a better approach for this. with my patch, bot-added properties that we don't want suggested (e.g. freebase identifiers) might appear in suggestions. |
|
would like approach in #87 instead of this. (rebased in https://github.com/Wikidata-lib/PropertySuggester/tree/initialSuggestionsRebased) |
There used to be (?) suggestions (e.g. P31) for items with no statements yet.
This provides suggestions by item when there are no property ids used yet on the item, suggesting overall most used properties like P31 that users may want to start with on an empty item.
Bug: T92748