Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image usage #1011

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Update docker image usage #1011

merged 2 commits into from
Jun 2, 2022

Conversation

jsnshrmn
Copy link
Member

@jsnshrmn jsnshrmn commented Jun 2, 2022

Description

  • rm perl/Dockerfile
  • use wikipedialibrary updated images

Rationale

Perl image used for static analysis was never getting updated. Now that is happening here:
https://github.com/WikipediaLibrary/wikipedialibrary_container_image_ops/actions
Along with other updates, which we can leverage by updated the image tags we use.

Phabricator Ticket

https://phabricator.wikimedia.org/T308169

How Has This Been Tested?

The image builds are now working as needed

Screenshots of your changes (if appropriate):

N/A

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@jsnshrmn jsnshrmn changed the title rm perl/Dockerfile Update docker image usage Jun 2, 2022
@jsnshrmn jsnshrmn requested a review from suecarmol June 2, 2022 15:06
Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suecarmol suecarmol merged commit 0cc6e3a into master Jun 2, 2022
@jsnshrmn jsnshrmn deleted the jason-T308169 branch October 20, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants