proxy approval email #330
Merged
proxy approval email #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I getting some unexpected ezproxy test failures with this locally, so I'm just going to circle back around to it with fresh eyes, or have @Samwalton9 take a look for something silly. |
|
Passes all tests on Travis... Interesting. |
|
and really, get_user_instructions() should probably live in resources instead of applications. |
Samwalton9
reviewed
Oct 19, 2019
jsnshrmn
force-pushed
the
dev-proxy-approval-email
branch
5 times, most recently
from
a27f4ce
to
02b26b0
Compare
…the appropriate user instructions via an application.
…instructions() instead of doing their own thing.
jsnshrmn
force-pushed
the
dev-proxy-approval-email
branch
from
02b26b0
to
52f5377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somewhat rejiggers where the static/template-based user instructions live.