-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Back-to-top' button for partners list page #410
Conversation
Could you add a screenshot of what this button looks like, please? :) |
@Samwalton9 Sure adding a gif file showing the working of the button :) |
Hello @Samwalton9 I thought you just missed this one, please have a look whenever you are free :) |
Hey lalit - thanks for the reminder. I'm actually going to wait on reviewing this. We've got a lot of moving pieces being merged in to the tool this month and it might just reduce complications to hold off on merging this PR until then. Sorry about that - we'll get to it in a few weeks :) |
Okay, no problem :) |
I rebased this so I can check it against our current code base and review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we've moved to an anonymizing reverse proxy for external assets, so it would be great if you updated the URLs to match what is in #447. Since you had no way of knowing that this change was about to happen, I'd be happy to make that update on your behalf if you don't want to. |
Fixed it, now working well in mobile view.
removed the javascript part. |
I have removed the urls, since they were already present in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and will be very useful once it's merged! I just want to request a small change before merging this.
The partners page is quite long now. A 'back to top' button was needed. Bug: T170113
The partners page is quite long now. A 'back to top' button was needed.
Bug: T170113