Show recently filed applications and their date

[lalit97]

Description

Show all applications filed in last 3 months and their submission date, on application evaluation page.

Rationale

Before this we used to show 5 recent applications on evaluation page. But we need to display more applications on that page so coordinators can decide if a user is applying indiscriminately.

Phabricator Ticket

T262904

How Has This Been Tested?

I have added 2 new tests for this behaviour. Also removed a test which was previously used to test rendering of 5 recent applications only.
This change can be tested manually by going on application evaluation page and checking recent applications section.

Screenshots of your changes:

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

[lalit97]

I have broke down the task of showing recent applications in following 2 ways

(1) If there are more than 5 applications present in the period of last 3 months than I thought it will be good if we display all of them instead of just limiting to 5 applications. Because that will give coordinators a more clear picture of if an editor has applied indiscriminately.

(2) If there are less than 5 applications present in the period of last 3 months than I thought it will be good if we add some more applications from past i.e. applications which are older than 3 months time period. So that we can show at least 5 recent applications.
But if there were less than 5 total applications made by an editor than we have to show less than 5 recent applications.

Also the diff of applications/tests.py is not showing properly I have tried to make separate commits and to make the diff look better by deleting the previous test and then adding the 2 new tests. But they are mixing somehow.

[Samwalton9]

If there are more than 5 applications present in the period of last 3 months than I thought it will be good if we display all of them instead of just limiting to 5 applications. Because that will give coordinators a more clear picture of if an editor has applied indiscriminately.

I think this makes sense to me, good suggestion.

If there are less than 5 applications present in the period of last 3 months than I thought it will be good if we add some more applications from past i.e. applications which are older than 3 months time period. So that we can show at least 5 recent applications.

I think this, however, over-complicates things. We should show coordinators as little information as necessary to make a decision - seeing applications made more than 3 months ago doesn't, in my opinion, help them make a decision. So I think it should only show last-3-months applications in this case.

Also the diff of applications/tests.py is not showing properly I have tried to make separate commits and to make the diff look better by deleting the previous test and then adding the 2 new tests. But they are mixing somehow.

One of the engineers can confirm, but I think this is just a quirk of how Github is calculating the diff, I wouldn't worry :)

[lalit97]

I think this makes sense to me, good suggestion.

Thanks :)

I think this, however, over-complicates things. We should show coordinators as little information as necessary to make a decision - seeing applications made more than 3 months ago doesn't, in my opinion, help them make a decision. So I think it should only show last-3-months applications in this case.

Okay got your point will make changes according to this. Also I have a design query if for an editor there are 0 applications found in last-3-months then should we show an empty table in Recent Applications sections or should we do not show the whole Recent Applications section(i.e. not even the heading) or maybe we can show a message below the heading that no applications are made recently. Which one should I pick for this case?

One of the engineers can confirm, but I think this is just a quirk of how Github is calculating the diff, I wouldn't worry :)

Okay if you or any other member does not face any difficulty while reviewing the changes then it is okay, otherwise I will try to come up with some solution if there is any :)

[Samwalton9]

Also I have a design query if for an editor there are 0 applications found in last-3-months then should we show an empty table in Recent Applications sections or should we do not show the whole Recent Applications section(i.e. not even the heading) or maybe we can show a message below the heading that no applications are made recently. Which one should I pick for this case?

In this case I think it would be best to show no table or information.

[suecarmol]

Thank you for your PR! This is looking great, but some changes need to be made in order to merge this 🙂

[suecarmol]

Thank you for the changes you made! This LGTM!

[lalit97]

Thank you :)