Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link new homepage to root of project #743

Merged
merged 5 commits into from
Jul 12, 2021
Merged

Link new homepage to root of project #743

merged 5 commits into from
Jul 12, 2021

Conversation

suecarmol
Copy link
Contributor

@suecarmol suecarmol commented Jul 1, 2021

Description

Link new homepage to root of TWLight and create new tests for the new view.

Rationale

Currently, the redesigned Wikipedia Library homepage is located at /homepage instead of the root of the project. This PR will replace the old homepage with the new one.

Additionally, the new homepage view did not have tests, so tests were added in this PR.

Phabricator Ticket

T285822

How Has This Been Tested?

  • Created automated tests to check if filters are working properly.
  • Manual tests

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@suecarmol suecarmol requested a review from jsnshrmn July 1, 2021 23:47
Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a read through and also tested locally. It looks good! I do have one comment inline, but it's not a blocker; Not merging right now due to our deployment freeze for the next week.

TWLight/tests.py Show resolved Hide resolved
@jsnshrmn jsnshrmn merged commit 287a381 into WikipediaLibrary:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants