Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix horizontal scroll bar #805

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

akayjoshi
Copy link
Contributor

Description

In My Library, there is a small amount of white space that causes a horizontal scroll bar. it should not display that horizontal scroll bar so the library fits the screen 100%.

Phabricator Ticket

https://phabricator.wikimedia.org/T289256

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@akayjoshi akayjoshi marked this pull request as ready for review September 5, 2021 11:41
Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. Users that use The Wikipedia Library on their phones will appreciate it! One small addition you need to make for this PR is to add the overflow-hidden class to the new-local-rtl.css file: https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/static/css/new-local.rtl.css#L23. This class should only have overflow: hidden attribute.

@akayjoshi
Copy link
Contributor Author

Hi suecarmol, I have a quetion. Do we need to add overflow-hidden class in /static/css/new-local.css also.

@suecarmol
Copy link
Contributor

Hi suecarmol, I have a quetion. Do we need to add overflow-hidden class in /static/css/new-local.css also.

No, I don't think that's necessary because the overflow-hidden exists in the bootstrap 4 css. It's funny that this class doesn't exist in the RTL bootstrap 4 version.

@akayjoshi
Copy link
Contributor Author

Hi suecarmol, I have pushed a new commit for this, thanks.

Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked in RTL and LTR languages, and the horizontal scroll bar bug is fixed. Thank you for your contribution!

@suecarmol suecarmol merged commit d94b279 into WikipediaLibrary:master Sep 9, 2021
@akayjoshi
Copy link
Contributor Author

Thank you 😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants