Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include multidisciplinary tag in tag filters #812

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Include multidisciplinary tag in tag filters #812

merged 2 commits into from
Sep 14, 2021

Conversation

suecarmol
Copy link
Contributor

Description

Include the multidisciplinary_tag when filtering by other tags.

Rationale

Since multidisciplinary collections may have content by which that tag is filtered, they should be included in the filter.

Phabricator Ticket

T289253

How Has This Been Tested?

Added test cases on existing cases.

Manual testing:

  1. Go to My Library
  2. Filter the collections by a tag
  3. Check that the collections are filtered by that tag and that multidisciplinary collections are also included

Screenshots of your changes (if appropriate):

Results when filtering by History tag
Screen Shot 2021-09-13 at 16 39 45

Screen Shot 2021-09-13 at 16 39 53

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@suecarmol
Copy link
Contributor Author

@Samwalton9 I think this PR can also be merged with your review (it's a fairly straightforward change).

@Samwalton9
Copy link
Member

This looks good to me and I sorted my local environment out so I could test locally and it seems to be working as intended!

@Samwalton9 Samwalton9 merged commit 36daf2a into WikipediaLibrary:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants