Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for xml? #10

Closed
mgajda opened this issue Jul 8, 2021 · 6 comments
Closed

Support for xml? #10

mgajda opened this issue Jul 8, 2021 · 6 comments

Comments

@mgajda
Copy link

mgajda commented Jul 8, 2021

XML documents have structure similar to that of parenthesised languages:
<block> is opening parenthesis, </block> is the closing one.
Is there any plan to support XML/HTML?

@mgajda mgajda changed the title Support for xml? [enhanacement]Support for xml? Jul 8, 2021
@Wilfred
Copy link
Owner

Wilfred commented Jul 16, 2021

It's an interesting idea. The extremely simple parser in difftastic using syntax.toml wouldn't work well XML's delimiters.

If we used something like roxmltree (an XML parser that preserves comments), we could use difftastic's internal AST and diffing would just work for XML.

I'm going to close this issue for now: it's not a goal before 1.0.

@Wilfred Wilfred closed this as completed Jul 16, 2021
Wilfred pushed a commit that referenced this issue Sep 6, 2021
handle newline before and after dot
Wilfred pushed a commit that referenced this issue Jan 30, 2022
Wilfred pushed a commit that referenced this issue Mar 20, 2022
igorclark pushed a commit to igorclark/difftastic that referenced this issue Mar 28, 2022
jbr pushed a commit to jbr/difftastic that referenced this issue Mar 30, 2022
Wilfred pushed a commit that referenced this issue Apr 14, 2022
Migrate CI to GitHub Actions
ido77778 pushed a commit to ido77778/difftastic that referenced this issue May 3, 2022
Wilfred pushed a commit that referenced this issue Jul 11, 2022
Support aliases without explicit AS keyword
@DaKnig
Copy link

DaKnig commented Jul 8, 2023

hi! just wanted to bring your attention to tree-sitter-xml, if that could help. I am also interested in getting xml supported.

@BerengarWLehr
Copy link

Would love xml support as well

@mgunyho
Copy link

mgunyho commented Aug 31, 2023

I'm interested in this as well. I have recently tried this tree-sitter xml parser with some simple SVG files and it seems to work: https://github.com/ObserverOfTime/tree-sitter-xml

@Wilfred Wilfred reopened this Aug 31, 2023
@Wilfred Wilfred changed the title [enhanacement]Support for xml? Support for xml? Aug 31, 2023
@Wilfred Wilfred closed this as completed in 9134593 Sep 9, 2023
@DaKnig
Copy link

DaKnig commented Sep 9, 2023

please add .ui files to the xml extension list, thats the extension used by many gnome apps for their xml buildable files

@Wilfred
Copy link
Owner

Wilfred commented Sep 9, 2023

@DaKnig done :)

Duologic pushed a commit to Duologic/difftastic that referenced this issue Mar 22, 2024
Followed the official spec for the precedence values.

test plan:
make test
bernhard-herzog pushed a commit to bernhard-herzog/difftastic that referenced this issue May 2, 2024
Added Unicode versions of builtin operators to highlight queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants