Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance unconditionally on equal nodes #47

Closed
Wilfred opened this issue Oct 18, 2021 · 1 comment
Closed

Advance unconditionally on equal nodes #47

Wilfred opened this issue Oct 18, 2021 · 1 comment

Comments

@Wilfred
Copy link
Owner

Wilfred commented Oct 18, 2021

When the source and target cursors are over identical subtrees, we always advance both cursors.

https://fazzone.github.io/autochrome.html

Difftastic considers advancing a single side, which might be wasteful.

@Wilfred
Copy link
Owner Author

Wilfred commented Oct 18, 2021

This might be a speed up, but it would do an arguably worse job on AXAB vs AB.

gurjeet pushed a commit to gurjeet/difftastic that referenced this issue Sep 20, 2022
Wilfred pushed a commit to Thecentury/difftastic that referenced this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant