Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify error handling behavior for nested transactions in docs #1160

Merged
merged 1 commit into from Apr 3, 2024
Merged

Clarify error handling behavior for nested transactions in docs #1160

merged 1 commit into from Apr 3, 2024

Conversation

nikwen
Copy link
Contributor

@nikwen nikwen commented Mar 16, 2024

I spent two hours reading the SQLite documentation and the better-sqlite3 source code. Thought this might help other people as well.

Thanks for the great library!

@nikwen nikwen requested a review from JoshuaWise as a code owner March 16, 2024 16:31
mceachen
mceachen approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nikwen
Copy link
Contributor Author

nikwen commented Mar 17, 2024

Thanks for the review, @mceachen!

@JoshuaWise JoshuaWise merged commit ac8f293 into WiseLibs:master Apr 3, 2024
14 checks passed
@nikwen
Copy link
Contributor Author

nikwen commented Apr 3, 2024

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mceachen mceachen mceachen approved these changes

@JoshuaWise JoshuaWise Awaiting requested review from JoshuaWise JoshuaWise is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikwen @mceachen @JoshuaWise