Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate \markdownInfo, \markdownWarning, and \markdownError #398

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Jan 18, 2024

Closes #383.

Tasks

  • Replace all instances of \markdownInfo, \markdownWarning, and \markdownError with l3msg functions.
  • Deprecate \markdownInfo, \markdownWarning, and \markdownError

@Witiko Witiko added technical debt Related to code smells and refactoring expl3 Related to the high-level programming language expl3 labels Jan 18, 2024
@Witiko Witiko force-pushed the fix/logging branch 3 times, most recently from 205f0fa to 7ae3a5c Compare January 18, 2024 13:13
@Witiko Witiko force-pushed the fix/logging branch 2 times, most recently from ab7f6e3 to 78281c4 Compare January 18, 2024 14:06
@Witiko Witiko marked this pull request as draft January 18, 2024 14:27
This will prevent unintended effects. For example, in Markdown 3.3.0,
the Markdown theme `witiko/tilde` has changed from a LaTeX theme
(file `markdownthemewitiko_tilde.sty`) to a plain TeX theme (file
`markdownthemewitiko_tilde.tex`). However, with the Docker image,
loading the Markdown theme `witiko/tilde` in LaTeX would load the
distribution file `markdownthemewitiko_tilde.sty` instead of the
current file `markdownthemewitiko_tilde.tex`, which is unexpected.
@Witiko Witiko merged commit 322ce98 into main Jan 18, 2024
12 checks passed
@Witiko Witiko deleted the fix/logging branch January 18, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expl3 Related to the high-level programming language expl3 technical debt Related to code smells and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate \markdownInfo, \markdownWarning, and \markdownError
1 participant