Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate \markdownInfo, \markdownWarning, and \markdownError #383

Closed
Witiko opened this issue Dec 16, 2023 · 1 comment · Fixed by #398
Closed

Deprecate \markdownInfo, \markdownWarning, and \markdownError #383

Witiko opened this issue Dec 16, 2023 · 1 comment · Fixed by #398
Labels
expl3 Related to the high-level programming language expl3 technical debt Related to code smells and refactoring
Milestone
3.4.1

Comments

@Witiko
Copy link
Owner

Witiko commented Dec 16, 2023 •
edited
Loading

For logging, the markdown package currently uses both the macros \markdownInfo, \markdownWarning, and \markdownError that predate the adoption of expl3 around version 2.11.0, and the logging functions of the l3msg module of the expl3 language. Unlike the l3msg functions, the macros don't allow much control about expansion.

Tasks

  • Replace all instances of \markdownInfo, \markdownWarning, and \markdownError with l3msg functions.
  • Deprecate \markdownInfo, \markdownWarning, and \markdownError
@Witiko Witiko added quality of life Related to quality-of-life improvements to the interface expl3 Related to the high-level programming language expl3 labels Dec 16, 2023
@Witiko Witiko added this to the 3.3.0 milestone Dec 16, 2023
@Witiko Witiko modified the milestones: 3.3.0, 3.4.0 Dec 29, 2023
@Witiko Witiko added technical debt Related to code smells and refactoring and removed quality of life Related to quality-of-life improvements to the interface labels Jan 18, 2024
@Witiko Witiko changed the title Replace all instances of \markdownInfo, \markdownWarning, and \markdownError with l3msg functions Deprecate \markdownInfo, \markdownWarning, and \markdownError Jan 18, 2024
@Witiko Witiko mentioned this issue Jan 18, 2024
Merged
2 tasks
@Witiko Witiko reopened this Feb 10, 2024
@Witiko Witiko modified the milestones: 3.4.0, 3.5.0 Feb 10, 2024
@Witiko Witiko closed this as completed Feb 10, 2024
@Witiko Witiko modified the milestones: 3.5.0, 3.4.0 Feb 10, 2024
@Witiko
Copy link
Owner Author

Witiko commented Feb 10, 2024

Not all instances of \markdownInfo, \markdownWarning, and \markdownError were replaced with l3msg functions in #398. Reopening.

@Witiko Witiko reopened this Feb 10, 2024
@Witiko Witiko modified the milestones: 3.4.0, 3.5.0, 3.4.1 Feb 10, 2024
@Witiko Witiko closed this as completed in 8451ef6 Feb 12, 2024
Witiko added a commit that referenced this issue Feb 12, 2024
@Witiko
Define \markdown{Info,Warning,Error} using l3msg
e64e891 
Even though the macros are still used in the code, they are now
essentially shorthands for l3msg logging and will be removed as
the code base develops. Closes #383.
Witiko added a commit that referenced this issue Feb 12, 2024
@Witiko
Define \markdown{Info,Warning,Error} using l3msg
e3ca682 
Even though the macros are still used in the code, they are now
essentially shorthands for l3msg logging and will be removed as
the code base develops. Closes #383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expl3 Related to the high-level programming language expl3 technical debt Related to code smells and refactoring
Projects
None yet
Milestone
3.4.1
Development

Successfully merging a pull request may close this issue.

Deprecate \markdownInfo, \markdownWarning, and \markdownError Witiko/markdown
1 participant
@Witiko