We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tabs.executeScript()
import()
Maybe. Using dynamic imports makes us have to add web_accessible_resources:
web_accessible_resources
jumpcutter/src/manifest.json
Lines 26 to 30 in 81b4e50
web-ext
jumpcutter/src/native-dynamic-import-webpack-plugin/LoadScriptRuntimeModule.js
Line 39 in 81b4e50
runtime.getURL(
But then, it sounds a little stupid that there's virtually no native support for dynamic importing in extensions. Or am I missing something?
Another big thing is with .audioWorklet.addModule:
.audioWorklet.addModule
jumpcutter/src/entry-points/content/StretchingController/StretchingController.ts
Line 164 in 81b4e50
executeScript()
This may also help with #26
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Maybe.
Using dynamic imports makes us have to add
web_accessible_resources
:jumpcutter/src/manifest.json
Lines 26 to 30 in 81b4e50
It's also a little dangerous to not have the import URL set in stone, maybe it could be somehow manipulated by a malicious page to import something else on behalf of the extension (Mozilla's
web-ext
warns about this).jumpcutter/src/native-dynamic-import-webpack-plugin/LoadScriptRuntimeModule.js
Line 39 in 81b4e50
Edit: Actually this doesn't look super dangerous, since we're passing the string through
runtime.getURL(
,But then, it sounds a little stupid that there's virtually no native support for dynamic importing in extensions. Or am I missing something?
Another big thing is with
.audioWorklet.addModule
:jumpcutter/src/entry-points/content/StretchingController/StretchingController.ts
Line 164 in 81b4e50
executeScript()
. Maybe the spec needs to be changed. I don't know what's the best practice.This may also help with #26
The text was updated successfully, but these errors were encountered: