Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate template directories #5879

Open
mutec opened this issue Apr 13, 2024 · 1 comment
Open

Separate template directories #5879

mutec opened this issue Apr 13, 2024 · 1 comment

Comments

@mutec
Copy link
Contributor

mutec commented Apr 13, 2024

A few minutes before I failed to install the bleeding edge version since it tries to load the benachmark-template when starting the action WCFSetup. The mentioned templates is a shared template. Shared templates are currently deployed within the template-PIP, so they aren't deployed then starting the action. WCFSetup runs already using the final acp which means it also requires this shared template, which is not deployed yet.

I'd prefer overhauling the template-directory structure. I thought about something like:

acp/
 ├─ templates/
 │  ├─ compiled/
templates/
 ├─ compiled/
 ├─ custom/
 │  ├─ style-1/
 │  ├─ style-2/
 ├─ email/
 ├─ shared/

Within the compiled directories it could be separated to different sub-directories or a more complex file-naming.

@Cyperghost
Copy link
Contributor

@mutec this commit should solve the installation problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants