Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP API to update database tables #3065

Merged
merged 8 commits into from
Sep 29, 2019
Merged

Add PHP API to update database tables #3065

merged 8 commits into from
Sep 29, 2019

Conversation

Gravatronics
Copy link
Contributor

See #2847

@Gravatronics Gravatronics added this to the 5.2 milestone Sep 1, 2019
@dtdesign dtdesign mentioned this pull request Sep 1, 2019
Closed
3 tasks
joshuaruesweg
joshuaruesweg reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@joshuaruesweg joshuaruesweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for my comment and Tim's, it looks good.

wcfsetup/install/files/lib/system/database/table/index/DatabaseTableForeignKey.class.php Show resolved Hide resolved
@Gravatronics
Check if foreign key has an action
38d2e2e
@Gravatronics
Update logging procedure of database change
3de2e19 
1. Create a log entry marked as not done yet
2. Execute the change
3. Mark the log entry as done

(When deleting a component, no log entry is created and the relevant log entry is deleted in the end.)
@Gravatronics Gravatronics mentioned this pull request Sep 8, 2019
Closed
@dtdesign dtdesign merged commit ae3febe into next Sep 29, 2019
@Gravatronics Gravatronics deleted the db_update_api branch September 29, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla left review comments

@joshuaruesweg joshuaruesweg joshuaruesweg left review comments

@dtdesign dtdesign dtdesign approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Gravatronics @dtdesign @TimWolla @joshuaruesweg