Work around bug in createImageBitmap in Chrome #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
commented
Apr 26, 2020
Google Chrome returns inconsistent sizing between `img.(width|height)` and the (width|height) of the bitmap returned by `createImageBitmap()`. See: https://bugs.chromium.org/p/chromium/issues/detail?id=1069965 This mismatch causes Pica to corrupt the resulting image. This commit disables resizing when the bug is detected. The behavior might need to be re-adjusted depending on what behavior Chrome's fix will result in.
TimWolla
force-pushed
the
resize-chrome-bug
branch
from
baf4f89
to
45be41e
Compare
dtdesign
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Chrome returns inconsistent sizing between
img.(width|height)andthe (width|height) of the bitmap returned by
createImageBitmap().See: https://bugs.chromium.org/p/chromium/issues/detail?id=1069965
This mismatch causes Pica to corrupt the resulting image.
This commit disables resizing when the bug is detected. The behavior might
need to be re-adjusted depending on what behavior Chrome's fix will result
in.