Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option name validators to devtools form for the option PIP #3988

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Add option name validators to devtools form for the option PIP #3988

merged 2 commits into from
Mar 8, 2021

Conversation

TimWolla
Copy link
Member

see #3966

@TimWolla TimWolla mentioned this pull request Feb 12, 2021
Closed
@TimWolla TimWolla force-pushed the devtools-option-name-validator branch from 5386d1d to 66b15af Compare February 12, 2021 11:12
Gravatronics
Gravatronics suggested changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@Gravatronics Gravatronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM.

wcfsetup/install/lang/de.xml Outdated Show resolved Hide resolved
@TimWolla @Gravatronics
Improve phrasing for optionName pattern error message
94e3bfe 
Co-authored-by: Matthias Schmidt <gravatronics@live.com>
@TimWolla TimWolla merged commit 4470544 into master Mar 8, 2021
@TimWolla TimWolla deleted the devtools-option-name-validator branch March 8, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gravatronics Gravatronics Gravatronics requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWolla @Gravatronics