Remove add() and update() from ISearchIndexManager #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are long-deprecated, remove them from the interface to not force search engine authors to implement these. It is expected that code consuming the search API uses the `SearchIndexManager` class instead of directly accessing a specific `*SearchIndexManager`. The `SearchIndexManager` only uses `->set()` on the underlying actual `*SearchIndexManager`. Thus no compatibility break is expected.
dtdesign
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are long-deprecated, remove them from the interface to not force
search engine authors to implement these.
It is expected that code consuming the search API uses the
SearchIndexManagerclass instead of directly accessing a specific
*SearchIndexManager. TheSearchIndexManageronly uses->set()on the underlying actual*SearchIndexManager. Thus no compatibility break is expected.