Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y in give shortcode #858

Merged
merged 3 commits into from
Aug 10, 2016
Merged

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Aug 10, 2016

Remove unneeded title attribute.

@DevinWalker
Copy link
Member

DevinWalker commented Aug 10, 2016

Thanks! Can you leave the "title" attribute on the anchor tag? It's cool to remove it from the inputs?

@ramiy
Copy link
Contributor Author

ramiy commented Aug 10, 2016

We can remove from inputs because the screen reader has the context in the label.


As for the a tag, when title is equal to the content inside the a tag, it can be removed.

From a11y perspective, you should use the title attribute in a tags carefully.

A good example is:

<a href="">View</a>

View what?

<a href="" title="View Payment">View</a>

Regular user can understand from the design that the "View" link means view payments.

But blind people don't see the context. The title attr help them to understand the link context.

@ramiy ramiy mentioned this pull request Aug 10, 2016
7 tasks
@DevinWalker
Copy link
Member

I gotcha, I was thinking for typical users when they hover the anchor and see the browsers tooltip that it's pretty helpful.

@DevinWalker DevinWalker merged commit 690c4d5 into impress-org:release/1.7 Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants