Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y in give shortcode #858

Merged
merged 3 commits into from
Aug 10, 2016
Merged

a11y in give shortcode #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a19e5c3
a11y on registration shortcode - remove the title attribute from the …
ramiy Aug 10, 2016
48397ae
a11y on login shortcode - remove the title attribute from the input f…
ramiy Aug 10, 2016
7fc4c6d
a11y on login shortcode - remove the title attribute from the passwor…
ramiy Aug 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions templates/shortcode-login.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
?>
<div class="give-login-username give-login">
<label for="give_user_login"><?php esc_html_e( 'Username', 'give' ); ?></label>
<input name="give_user_login" id="give_user_login" class="give-required give-input" type="text" title="<?php esc_attr_e( 'Username', 'give' ); ?>" />
<input name="give_user_login" id="give_user_login" class="give-required give-input" type="text" />
</div>

<div class="give-login-password give-login">
<label for="give_user_pass"><?php esc_html_e( 'Password', 'give' ); ?></label>
<input name="give_user_pass" id="give_user_pass" class="give-password give-required give-input" type="password" />
Expand All @@ -37,7 +38,7 @@
</div>

<div class="give-lost-password give-login">
<a href="<?php echo wp_lostpassword_url(); ?>" title="<?php esc_attr_e( 'Lost Password', 'give' ); ?>"><?php esc_html_e( 'Lost Password?', 'give' ); ?></a>
<a href="<?php echo wp_lostpassword_url(); ?>"><?php esc_html_e( 'Lost Password?', 'give' ); ?></a>
</div>
<?php
/**
Expand Down
4 changes: 2 additions & 2 deletions templates/shortcode-register.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@

<div class="form-row form-row-first">
<label for="give-user-login"><?php esc_html_e( 'Username', 'give' ); ?></label>
<input id="give-user-login" class="required give-input" type="text" name="give_user_login" title="<?php esc_attr_e( 'Username', 'give' ); ?>" />
<input id="give-user-login" class="required give-input" type="text" name="give_user_login" />
</div>

<div class="form-row form-row-last">
<label for="give-user-email"><?php esc_html_e( 'Email', 'give' ); ?></label>
<input id="give-user-email" class="required give-input" type="email" name="give_user_email" title="<?php esc_attr_e( 'Email Address', 'give' ); ?>" />
<input id="give-user-email" class="required give-input" type="email" name="give_user_email" />
</div>

<div class="form-row form-row-first">
Expand Down