PrefixAllGlobals: improve error message clarity #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When people run the sniffs without the `-s` option, the messages for some of the errors in this sniff were not specific enough as the "Prefix**AllGlobals**" part would not be seen. I considered adjusting the error message template `ERROR_MSG`, however, this would cause more confusion as, for instance, namespace declarations will **always** be in the global namespace. So, I've opted to adjust select error messages instead.
NielsdeBlaauw
approved these changes
Feb 19, 2019
GaryJones
approved these changes
Feb 19, 2019
|
Just checking, is this waiting for something ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When people run the sniffs without the
-soption, the messages for some of the errors in this sniff were not specific enough as the "PrefixAllGlobals" part would not be seen.I considered adjusting the error message template
ERROR_MSG, however, this would cause more confusion as, for instance, namespace declarations will always be in the global namespace.So, I've opted to adjust select error messages instead.
Issue identified by @justintadlock in WPTT/WPThemeReview#200 (comment)