IsUnitTestTrait: update test class list #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingo-d
approved these changes
May 15, 2022
GaryJones
approved these changes
May 16, 2022
|
@GaryJones Just checking - any particular reason why you didn't merge this after approving (as the second approver) ? Same for the other open PR. |
|
FYI: As I've now changed the required statuses, I will rebase this PR (and the other open one) without changes, so the required statuses pass again. |
Update the test class list based on changes in WP Core: * The `Block_Supported_Styles_Test` was never a `TestCase`, but was a concrete test placed in the wrong directory. * The `PHPUnit_Adapter_TestCase` class was added to allow for PHPUnit cross-version support. Other than that, the list is now alphabetized within each category and the categories are annotated with comments.
jrfnl
force-pushed
the
feature/unittesttrait-update-class-list
branch
from
a4c2f90
to
20d906d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the test class list based on changes in WP Core:
Block_Supported_Styles_Testwas never aTestCase, but was a concrete test placed in the wrong directory.PHPUnit_Adapter_TestCaseclass was added to allow for PHPUnit cross-version support.Other than that, the list is now alphabetized within each category and the categories are annotated with comments.